-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cleanup] Remove future imports from tests and utils #6050
Conversation
d644db7
to
5990431
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this. Note a future PR should probably remove the # -*- coding: utf-8 -*-
line since UTF-8 is the default encoding in Python 3.
tests/druid_func_tests.py
Outdated
@@ -33,6 +28,8 @@ def emplace(metrics_dict, metric_name, is_postagg=False): | |||
# Unit tests that can be run without initializing base tests | |||
class DruidFuncTestCase(unittest.TestCase): | |||
|
|||
_multiprocess_can_split_ = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to be here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops
5990431
to
b0b237f
Compare
b0b237f
to
e555d99
Compare
Codecov Report
@@ Coverage Diff @@
## master #6050 +/- ##
==========================================
- Coverage 77.81% 77.78% -0.03%
==========================================
Files 46 46
Lines 9446 9434 -12
==========================================
- Hits 7350 7338 -12
Misses 2096 2096
Continue to review full report at Codecov.
|
PING |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you removed these only from the tests. Surely there are more instances of these.
I chunked it into smaller pieces so it's easier to review. This PR only covers the tests. The other PRs cover the other parts. |
Since we now no longer support python2, This PR starts taking out the future imports from tests and utils.
I will follow up with the same thing for other parts of the code base and also do the same for six and utf8.
@john-bodley @mistercrunch