[bugfix] fix rows not showing on welcome page (retry) #5849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an attempt to try #5847 again which get stuck on CI, but it seems like same issue, so I'll just wait. |
Codecov Report
@@ Coverage Diff @@
## master #5849 +/- ##
=========================================
+ Coverage 63.75% 63.8% +0.04%
=========================================
Files 374 374
Lines 23320 23443 +123
Branches 2608 2621 +13
=========================================
+ Hits 14867 14957 +90
- Misses 8440 8473 +33
Partials 13 13
Continue to review full report at Codecov.
|
|
@graceguo-supercat CI is back. Good to merge now. 😀 |
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* fix rows not showing on welcome page * remove test code * bring filter back * remove empty line * remove another empty line * remove comment
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* fix rows not showing on welcome page * remove test code * bring filter back * remove empty line * remove another empty line * remove comment
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reactableversion to 1.1.0@graceguo-supercat