Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Fix] Fixed the wrong icon for Source -> Table #5574

Merged
merged 1 commit into from
Aug 7, 2018
Merged

[Bug Fix] Fixed the wrong icon for Source -> Table #5574

merged 1 commit into from
Aug 7, 2018

Conversation

conglei
Copy link
Contributor

@conglei conglei commented Aug 7, 2018

The icon for Source -> Table was wrong.

Before:

screen shot 2018-08-06 at 5 08 27 pm

After:

screen shot 2018-08-06 at 5 08 38 pm

williaster
williaster approved these changes Aug 7, 2018
View reviewed changes
Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kristw
Copy link
Contributor

kristw commented Aug 7, 2018

Approved.

@williaster williaster merged commit ad469c7 into apache:master Aug 7, 2018
@codecov-io
Copy link

codecov-io commented Aug 7, 2018 •
edited
Loading

Codecov Report

Merging #5574 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5574   +/-   ##
=======================================
  Coverage   63.58%   63.58%           
=======================================
  Files         358      358           
  Lines       22742    22742           
  Branches     2530     2530           
=======================================
  Hits        14461    14461           
  Misses       8266     8266           
  Partials       15       15
Impacted Files Coverage Δ
superset/connectors/sqla/views.py 64.34% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68ba63f...91ee644. Read the comment docs.

kristw pushed a commit to airbnb/superset-fork that referenced this pull request Aug 13, 2018
@conglei @kristw
Fixed the wrong icon for Source -> Table (apache#5574)
c26ff0a 
(cherry picked from commit ad469c7)
@kristw kristw mentioned this pull request Aug 14, 2018
Closed
kristw pushed a commit to airbnb/superset-fork that referenced this pull request Aug 14, 2018
@conglei @kristw
Fixed the wrong icon for Source -> Table (apache#5574)
0e562c4 
(cherry picked from commit ad469c7)
@kristw kristw mentioned this pull request Aug 15, 2018
Merged
kristw pushed a commit to kristw/incubator-superset that referenced this pull request Aug 15, 2018
@conglei @kristw
Fixed the wrong icon for Source -> Table (apache#5574)
b6dcc7d 
(cherry picked from commit ad469c7)
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@conglei @williaster
Fixed the wrong icon for Source -> Table (apache#5574)
9f734a3
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williaster williaster williaster approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@conglei @kristw @codecov-io @williaster @mistercrunch