Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Cherry-pick(s): Bugfix multi-line chart and icon + unit test #87

Merged
merged 5 commits into from
Aug 15, 2018

Conversation

kristw
Copy link

@kristw kristw commented Aug 15, 2018

Cherry-pick the following commit(s):

SHA Time Log Author
1d7f4f2 Tue Aug 14 10:48:21 2018 -0700 [bugfix] line_multi chart crashed on chosen (apache#5568) (apache#5572) [Krist Wongsuphasawat]
ad469c7 Mon Aug 6 17:27:48 2018 -0700 Fixed the wrong icon for Source -> Table (apache#5574) [Conglei]

@graceguo-supercat @michellethomas @john-bodley @williaster

@kristw kristw changed the title [WIP] Cherry-pick(s): <description> Cherry-pick(s): Bugfix multi-line chart and icon + unit test Aug 15, 2018
@codecov-io
Copy link

codecov-io commented Aug 15, 2018

Codecov Report

Merging #87 into airbnb-master will decrease coverage by 13.97%.
The diff coverage is 28.57%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           airbnb-master      #87       +/-   ##
==================================================
- Coverage           77.2%   63.22%   -13.98%     
==================================================
  Files                 45      351      +306     
  Lines               8856    22042    +13186     
  Branches               0     2470     +2470     
==================================================
+ Hits                6837    13936     +7099     
- Misses              2019     8094     +6075     
- Partials               0       12       +12
Impacted Files Coverage Δ
superset/connectors/sqla/views.py 70.47% <ø> (ø) ⬆️
superset/assets/src/explore/visTypes.jsx 57.14% <ø> (ø)
superset/assets/src/visualizations/line_multi.js 0% <0%> (ø)
...sets/src/explore/components/DisplayQueryButton.jsx 84.74% <100%> (ø)
.../src/dashboard/components/RefreshIntervalModal.jsx 86.95% <0%> (ø)
superset/assets/src/logger.js 95.23% <0%> (ø)
...src/explore/components/controls/VizTypeControl.jsx 89.58% <0%> (ø)
superset/assets/src/visualizations/word_cloud.js 0% <0%> (ø)
superset/assets/src/components/ActionMenuItem.jsx 0% <0%> (ø)
...et/assets/src/visualizations/deckgl/layers/arc.jsx 0% <0%> (ø)
... and 300 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6ce0c1...54cc9a8. Read the comment docs.

@john-bodley john-bodley merged commit 3ebe44f into airbnb:airbnb-master Aug 15, 2018
@kristw kristw deleted the cherry-line-multi-v2 branch August 22, 2018 18:14
michellethomas pushed a commit that referenced this pull request Dec 1, 2021
* update version in package template

* change only first letter to uppercase

* update template

* add language choice
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants