Add additional heatmap schemas #5549

jerowe · 2018-08-02T15:10:48Z

jerowe · 2018-08-02T15:15:17Z

I'm not done, do not merge!

mistercrunch · 2018-08-02T17:07:55Z

Mind sharing screenshots of what the new options look like?

jerowe · 2018-08-03T12:49:23Z

In theory I could, but somehow I broke the npm build and I'm trying to get it working again. Once I get it working I am happy to post screenshots.

codecov-io · 2018-08-03T15:03:03Z

Codecov Report

Merging #5549 into master will increase coverage by 0.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5549      +/-   ##
==========================================
+ Coverage   63.36%   63.59%   +0.23%     
==========================================
  Files         351      359       +8     
  Lines       22258    22802     +544     
  Branches     2470     2534      +64     
==========================================
+ Hits        14104    14502     +398     
- Misses       8139     8285     +146     
  Partials       15       15

Impacted Files	Coverage Δ
superset/assets/src/explore/controls.jsx	`47.36% <ø> (+0.39%)`	⬆️
superset/assets/src/modules/colors.js	`77.55% <ø> (ø)`	⬆️
...explore/components/controls/SelectAsyncControl.jsx	`56% <0%> (-14%)`	⬇️
...erset/assets/src/explore/actions/exploreActions.js	`56.94% <0%> (-12.29%)`	⬇️
superset/assets/src/components/Button.jsx	`90.9% <0%> (-9.1%)`	⬇️
...ets/src/SqlLab/components/ExploreResultsButton.jsx	`82.97% <0%> (-4.21%)`	⬇️
...rc/explore/components/controls/CheckboxControl.jsx	`89.47% <0%> (-3.86%)`	⬇️
.../explore/components/controls/DatasourceControl.jsx	`66.17% <0%> (-1.83%)`	⬇️
superset/models/core.py	`85.16% <0%> (-1.41%)`	⬇️
superset/views/core.py	`73.83% <0%> (-0.15%)`	⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7f9dab...4046661. Read the comment docs.

jerowe · 2018-08-06T16:17:36Z

Pinging @mistercrunch

jerowe · 2018-08-06T16:19:38Z

@mistercrunch - I was thinking about changing some of the d3 colorschemes so that the first color (which is close to white) is dropped, but it seems that now missing blocks are gray. So maybe its not such a big deal?

jerowe · 2018-08-06T16:21:52Z

FYI - I lifted all the color schemas straight from here - https://github.com/d3/d3-scale-chromatic

jerowe · 2018-08-06T16:26:32Z

Hmmm I'm getting an error when I navigate to a dashboard, but I don't know why.

http://localhost:8088/superset/dashboard/deck/
http://localhost:8088/superset/dashboard/deck/

Uncaught TypeError: Cannot read property 'children' of undefined
    at t.default (dashboard.b259de2c9caaee2d7265.entry.js:111)
    at t.default (dashboard.b259de2c9caaee2d7265.entry.js:111)
    at Object.<anonymous> (dashboard.b259de2c9caaee2d7265.entry.js:102)
    at s (dashboard.b259de2c9caaee2d7265.entry.js:1)
    at Object.<anonymous> (dashboard.b259de2c9caaee2d7265.entry.js:102)
    at s (dashboard.b259de2c9caaee2d7265.entry.js:1)
    at n (dashboard.b259de2c9caaee2d7265.entry.js:1)
    at dashboard.b259de2c9caaee2d7265.entry.js:1
    at dashboard.b259de2c9caaee2d7265.entry.js:1

mistercrunch · 2018-08-06T16:37:38Z

@jerowe there was a bug on master, rebase your branch should fix that, also please remove the [WiP] from the PR title if ready for review

…into feature/heatmap-color-scales

jerowe · 2018-08-06T17:56:36Z

I will wait for the tests to complete and then remove the WIP.

jerowe · 2018-08-06T18:24:18Z

@mistercrunch this is all ready

jerowe · 2018-08-06T20:24:33Z

@mistercrunch , you see how in the calendar view the missing ones are grayed out? I like this. How possible would it be to get a PR to have that as an option for the other heatmap?

jerowe · 2018-08-07T14:42:42Z

ping @mistercrunch (sorry to be a pain but I really want this.)

jerowe · 2018-08-07T15:05:30Z

Ok and as long as we are talking about stuff I want:

Color select for missing values
Color select for values that don't make some cutoff (I think this will be harder since I always do the cutoff through sql )

mistercrunch · 2018-08-07T20:59:58Z

Indents seem off, should be 2 not 4. I don't understand why the linter doesn't fire on that.

jerowe · 2018-08-07T22:00:29Z

I tried to get my editor to go along with the project configs, but didn't quite get it perfect. Any tips? I use webstorm

mistercrunch · 2018-08-07T23:18:38Z

Use vim :)

jerowe · 2018-08-09T17:34:31Z

@mistercrunch , I fixed the indentation issues.

mistercrunch · 2018-08-09T17:52:21Z

@elibrumbaugh @williaster what do you think of adding these color schemes?

jerowe · 2018-08-09T18:04:41Z

ok now it is all ready

williaster · 2018-08-09T18:16:15Z

superset/assets/src/explore/controls.jsx

@@ -324,6 +324,40 @@ export const controls = {
      ['red_yellow_blue', 'red/yellowish/blue'],
      ['brown_white_green', 'brown/white/green'],
      ['purple_white_green', 'purple/white/green'],
+      ['schemeBrBG', 'd3BrBG'],


can you please make these more human readable? non-power users are not going to have any idea what BrBG means

sure. updated.

williaster · 2018-08-09T18:16:43Z

I'm fine with it, this isn't the long term solution we want (ideally Superset admins would be able to define the color schemes they want in a plugin-way) but fine for now 🤷‍♀️

cc @kristw

kristw · 2018-08-09T19:28:37Z

LGTM. I agree with @williaster
@jerowe I would recommend squashing your git commits and clean the commit messages a little bit as these messages will forever be stored in the main repo git log.
https://github.com/todotxt/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit

jerowe · 2018-08-09T20:41:34Z

@kristw , I just tried to squash my commits, but I'm not sure I was successful. Can they get squashed on merge?

* got skeleton started * added d3-scale-chromatic to package.json * got hex values instead of calling from a function * got rid of d3-scale-chromatic - no longer needed * added schemas to controls * damn editor broken some line spacing * commit * fix style issues * whyyyyy won't this build * whyyyyy won't this build * damn typo * hahaha got editor to deal with style configs * no i guess i didn't * gotta get them all * again * trying to get docker build ot work * updated installation docs with some osx instructions * restoring yarn.lock not sure why it changed * trying to fix indent * trying again * CODE STYLE CHANGES WORK * removing some colors that are too close to white * human readable labels for names * human readable labels for names

jerowe added 2 commits August 2, 2018 11:08

got skeleton started

6694b67

added d3-scale-chromatic to package.json

504e813

jerowe changed the title ~~Add additional heatmap schemas~~ [WIP] - Add additional heatmap schemas Aug 2, 2018

jerowe added 4 commits August 2, 2018 11:54

got hex values instead of calling from a function

eb7ec77

got rid of d3-scale-chromatic - no longer needed

71c2c45

added schemas to controls

b9d1f76

damn editor broken some line spacing

cefa588

jerowe added 4 commits August 2, 2018 13:51

commit

a7a27b5

fix style issues

a5008cb

whyyyyy won't this build

f40d1cc

whyyyyy won't this build

a1208fc

jerowe added 5 commits August 3, 2018 09:12

damn typo

429520d

hahaha got editor to deal with style configs

0076170

no i guess i didn't

64f74b5

gotta get them all

892e1f8

again

6461153

trying to get docker build ot work

c54e784

updated installation docs with some osx instructions

148dca1

restoring yarn.lock not sure why it changed

5eff534

Merge branch 'master' of https://github.com/apache/incubator-superset …

e8058bf

…into feature/heatmap-color-scales

jerowe changed the title ~~[WIP] - Add additional heatmap schemas~~ Add additional heatmap schemas Aug 6, 2018

jerowe added 3 commits August 9, 2018 12:15

trying to fix indent

2ac7855

trying again

613a2c9

CODE STYLE CHANGES WORK

28fa7a5

removing some colors that are too close to white

69d81ae

williaster reviewed Aug 9, 2018

View reviewed changes

jerowe added 2 commits August 9, 2018 16:32

human readable labels for names

16cc249

human readable labels for names

4046661

mistercrunch merged commit a39dfb9 into apache:master Aug 14, 2018

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add additional heatmap schemas #5549

Add additional heatmap schemas #5549

jerowe commented Aug 2, 2018

jerowe commented Aug 2, 2018

mistercrunch commented Aug 2, 2018

jerowe commented Aug 3, 2018

codecov-io commented Aug 3, 2018 •

edited

Loading

jerowe commented Aug 6, 2018

jerowe commented Aug 6, 2018

jerowe commented Aug 6, 2018

jerowe commented Aug 6, 2018 •

edited

Loading

mistercrunch commented Aug 6, 2018

jerowe commented Aug 6, 2018

jerowe commented Aug 6, 2018

jerowe commented Aug 6, 2018

jerowe commented Aug 7, 2018

jerowe commented Aug 7, 2018

mistercrunch commented Aug 7, 2018

jerowe commented Aug 7, 2018

mistercrunch commented Aug 7, 2018

jerowe commented Aug 9, 2018

mistercrunch commented Aug 9, 2018

jerowe commented Aug 9, 2018

williaster Aug 9, 2018

jerowe Aug 9, 2018

williaster commented Aug 9, 2018 •

edited

Loading

kristw commented Aug 9, 2018

jerowe commented Aug 9, 2018

Add additional heatmap schemas #5549

Add additional heatmap schemas #5549

Conversation

jerowe commented Aug 2, 2018

jerowe commented Aug 2, 2018

mistercrunch commented Aug 2, 2018

jerowe commented Aug 3, 2018

codecov-io commented Aug 3, 2018 • edited Loading

Codecov Report

jerowe commented Aug 6, 2018

jerowe commented Aug 6, 2018

jerowe commented Aug 6, 2018

jerowe commented Aug 6, 2018 • edited Loading

mistercrunch commented Aug 6, 2018

jerowe commented Aug 6, 2018

jerowe commented Aug 6, 2018

jerowe commented Aug 6, 2018

jerowe commented Aug 7, 2018

jerowe commented Aug 7, 2018

mistercrunch commented Aug 7, 2018

jerowe commented Aug 7, 2018

mistercrunch commented Aug 7, 2018

jerowe commented Aug 9, 2018

mistercrunch commented Aug 9, 2018

jerowe commented Aug 9, 2018

williaster Aug 9, 2018

Choose a reason for hiding this comment

jerowe Aug 9, 2018

Choose a reason for hiding this comment

williaster commented Aug 9, 2018 • edited Loading

kristw commented Aug 9, 2018

jerowe commented Aug 9, 2018

codecov-io commented Aug 3, 2018 •

edited

Loading

jerowe commented Aug 6, 2018 •

edited

Loading

williaster commented Aug 9, 2018 •

edited

Loading