Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Additional Color Gradients #4574

Closed
jerowe opened this issue Mar 8, 2018 · 7 comments
Closed

Feature Request - Additional Color Gradients #4574

jerowe opened this issue Mar 8, 2018 · 7 comments
Labels
enhancement:request Enhancement request submitted by anyone from the community inactive Inactive for >= 30 days

Comments

@jerowe
Copy link
Contributor

jerowe commented Mar 8, 2018

This is not a bug, but a feature request, or a point me towards code so I can do it request. ;-)

I would like to have some additional color gradient options, specifically for the heatmap. I have several heatmaps with thresholds, which leads to empty cells. These cells are white, but white is also a color in the gradient.

Please see attached. It is impossible to tell if values are empty, they did not make the cutoff, or if they are '1' (in this case).

heatmap-white-gradient

Thanks!

@BLiu1
Copy link

BLiu1 commented Jul 31, 2018

I have the same problem/interest in seeing this developed. A color palette creator would be appreciated.

@williaster williaster added the enhancement:request Enhancement request submitted by anyone from the community label Jul 31, 2018
@mistercrunch
Copy link
Member

Here's the source for the color spectrums:
https://github.com/apache/incubator-superset/blob/master/superset/assets/src/modules/colors.js#L94

References can be added here:
https://github.com/apache/incubator-superset/blob/8c822f1e9b566247ec94c368b45e36e7d767e90e/superset/assets/src/explore/controls.jsx#L314

This is a great resource, notice the "colorblind safe" option:
http://colorbrewer2.org/

Maybe we also need an "Empty Cell Color" colorpicker control to be added to the Heatmap viz.

@jerowe
Copy link
Contributor Author

jerowe commented Aug 2, 2018

I think I could get a start on this. Thanks for pointing me in the right direction!

@jerowe
Copy link
Contributor Author

jerowe commented Aug 2, 2018

Since d3 is already imported could I just use the d3 scales? I like those.

@mistercrunch
Copy link
Member

We use d3 scales behind the scene. The interface is an array of color though.

@jerowe
Copy link
Contributor Author

jerowe commented Aug 2, 2018

I have a script on my side that does a data dump of the d3 scales, so no need anymore.

@stale
Copy link

stale bot commented Apr 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 10, 2019
@stale stale bot closed this as completed Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement:request Enhancement request submitted by anyone from the community inactive Inactive for >= 30 days
Projects
None yet
Development

No branches or pull requests

4 participants