-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabled replicaCount #269
base: main
Are you sure you want to change the base?
Enabled replicaCount #269
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @angelsanchezdck , thanks for creating the pr!
Different deployments/statefulset uses different values, for example .Values.lake.replicaCount. Then you can delete the values.replicaCount part in values.yaml
Hi @ZhangNing10 , Done! ui: No limit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hi @angelsanchezdck , thanks a lot! could you kindly fix the conflict? |
Sorry for late. |
What is the next step? |
Enables the ability to set replicas of StatefulSet and deployments to 0, fully disabling the devlake-helm-chart. This ensures compliance with the requirement of having only one replica for deployments in dev-lake, providing finer control over the development environment.
Issue: #266