AWS: Update S3FileIO test to run when CLIENT_FACTORY is not set #9541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @nastra @amogh-jahagirdar for a review |
nastra
reviewed
Jan 25, 2024
aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIOIntegration.java
Outdated
Show resolved
Hide resolved
nastra
approved these changes
Jan 25, 2024
amogh-jahagirdar
approved these changes
Jan 25, 2024
|
Thanks @alok123t ! |
geruh
pushed a commit
to geruh/iceberg
that referenced
this pull request
Jan 26, 2024
adnanhemani
pushed a commit
to adnanhemani/iceberg
that referenced
this pull request
Jan 30, 2024
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the existing test to check
S3FileIOworks even with theCLIENT_FACTORYis not set. This update ensures the two tests below worktestS3FileIOWithDefaultAwsClientFactoryImpl- checks withDefaultAwsClientFactorytestS3FileIOWithS3FileIOAwsClientFactoryImpl- checks withDefaultS3FileIOAwsClientFactoryCurrently the existing tests
testS3FileIOWithDefaultAwsClientFactoryImplandtestS3FileIOWithS3FileIOAwsClientFactoryImplare duplicated.