Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Task Of [Feature] Move Rest Protocol to SPI Extensions #13958 #306

Merged
merged 32 commits into from
Apr 17, 2024

Conversation

wcy666103
Copy link
Contributor

What is the purpose of the change

XXXXX

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before
    you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address
    just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit
    in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency
    exist. If the new feature or significant change is committed, please remember to add sample
    in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure
    unit-test and integration-test pass.
  • If this contribution is large, please follow
    the Software Donation Guide.

@wcy666103
Copy link
Contributor Author

I have test it locally

@chintanpuggalok
Copy link

I guess there are some checkstyle failures
As per the build
Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.2:check (checkstyle-validation) on project dubbo-metadata-rest: You have 7 Checkstyle violations.

@AlbumenJ
Copy link
Member

AlbumenJ commented Apr 7, 2024

image
Still failed

@wcy666103
Copy link
Contributor Author

I guess there are some checkstyle failures As per the build Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.2:check (checkstyle-validation) on project dubbo-metadata-rest: You have 7 Checkstyle violations.

Tanks for your help

Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songxiaosheng songxiaosheng merged commit 7674dee into apache:master Apr 17, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants