Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broadcast support dubbo3.2 #238

Merged
merged 6 commits into from
Nov 18, 2023
Merged

Conversation

songxiaosheng
Copy link
Member

What is the purpose of the change

XXXXX

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before
    you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address
    just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit
    in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency
    exist. If the new feature or significant change is committed, please remember to add sample
    in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure
    unit-test and integration-test pass.
  • If this contribution is large, please follow
    the Software Donation Guide.

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do there any real changes take effect?

# Dubbo Cluster BroadCast 1

## Introduction
消费者发起广播调用所有提供者并获取所有提供者的调用结果。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please translate to english

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ce2288e) 33.98% compared to head (ff281e2) 33.38%.

Additional details and impacted files
@@             Coverage Diff              @@
##              3.2.0     #238      +/-   ##
============================================
- Coverage     33.98%   33.38%   -0.60%     
+ Complexity      515      513       -2     
============================================
  Files           158      161       +3     
  Lines          5391     5490      +99     
  Branches        666      671       +5     
============================================
+ Hits           1832     1833       +1     
- Misses         3354     3452      +98     
  Partials        205      205              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@songxiaosheng songxiaosheng merged commit aa85f78 into apache:3.2.0 Nov 18, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants