Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-SPECIFY-ADDRESS]support v2 ip spec #179

Merged
merged 3 commits into from
Dec 5, 2022

Conversation

wxbty
Copy link
Member

@wxbty wxbty commented Nov 28, 2022

What is the purpose of the change

Support dynamic ip access for non-local clusters.

Brief changelog

Similar to v3, build invoker for non-local cluster ip.

Currently pr only provides functions, and some codes may be shared with V3. In addition, a problem was found during the test. If the remote service times out, according to the default failover strategy, an invoker in the local cluster will be selected for execution, and an incorrect result will be obtained. This should also exist in V3 and needs to be resolved.
Issue Number: close #178

Verifying this change

Successful local test

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before
    you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address
    just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit
    in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency
    exist. If the new feature or significant change is committed, please remember to add sample
    in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure
    unit-test and integration-test pass.
  • If this contribution is large, please follow
    the Software Donation Guide.

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Please fix check style

@wxbty wxbty requested a review from AlbumenJ November 28, 2022 09:52
@wxbty wxbty changed the title support v2 ip spec [Dubbo-SPECIFY-ADDRESS]support v2 ip spec Nov 28, 2022
@AlbumenJ
Copy link
Member

image

Signed-off-by: x-shadow-man <1494445739@qq.com>
@wxbty
Copy link
Member Author

wxbty commented Nov 30, 2022

image

Refer to the test cases of V3, because they are almost the same. PTAL

@wxbty wxbty requested a review from AlbumenJ November 30, 2022 06:36
@AlbumenJ AlbumenJ merged commit 9312264 into apache:master Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exception of "User specified server address not support refer new url in Dubbo 2.x"
2 participants