Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: consumer invoker cache set nil after the ZK connection is lost #985

Merged
merged 20 commits into from
Feb 3, 2021
Merged

Fix: consumer invoker cache set nil after the ZK connection is lost #985

merged 20 commits into from
Feb 3, 2021

Conversation

jack15083
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@jack15083 jack15083 mentioned this pull request Jan 5, 2021
Closed
@jack15083 jack15083 changed the title 修复zk连接丢失后consumer端cache的provider服务被置空的bub 修复zk连接丢失后consumer端cache的provider服务被置空的bug Jan 5, 2021
@jack15083 jack15083 changed the title 修复zk连接丢失后consumer端cache的provider服务被置空的bug Fix: the provider invoker cache set nil after the ZK connection is lost Jan 5, 2021
@jack15083 jack15083 changed the title Fix: the provider invoker cache set nil after the ZK connection is lost Fix: counser invoker cache set nil after the ZK connection is lost Jan 5, 2021
@AlexStocks AlexStocks force-pushed the develop branch 2 times, most recently from ca6b03e to 34fa1da Compare January 6, 2021 02:12
Patrick0308
Patrick0308 reviewed Jan 6, 2021
View reviewed changes
config/reference_config.go Show resolved Hide resolved
remoting/zookeeper/client.go Show resolved Hide resolved
registry/zookeeper/registry.go Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Jan 7, 2021 •
edited
Loading

Codecov Report

Merging #985 (359482c) into develop (9130466) will increase coverage by 0.16%.
The diff coverage is 8.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #985      +/-   ##
===========================================
+ Coverage    59.56%   59.73%   +0.16%     
===========================================
  Files          261      261              
  Lines        12950    12906      -44     
===========================================
- Hits          7714     7709       -5     
+ Misses        4261     4225      -36     
+ Partials       975      972       -3
Impacted Files Coverage Δ
config/reference_config.go 79.41% <0.00%> (+0.56%) ⬆️
registry/zookeeper/registry.go 48.95% <0.00%> (-0.70%) ⬇️
remoting/zookeeper/client.go 60.46% <0.00%> (-0.36%) ⬇️
remoting/zookeeper/listener.go 44.16% <20.00%> (-1.07%) ⬇️
filter/filter_impl/metrics_filter.go 87.50% <0.00%> (-12.50%) ⬇️
...tocol/rest/server/server_impl/go_restful_server.go 43.90% <0.00%> (-4.88%) ⬇️
registry/etcdv3/listener.go 65.78% <0.00%> (-1.72%) ⬇️
registry/consul/registry.go 49.33% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9130466...c86547f. Read the comment docs.

@AlexStocks AlexStocks force-pushed the develop branch 5 times, most recently from 603f989 to 794ab77 Compare January 10, 2021 13:12
@AlexStocks AlexStocks changed the title Fix: counser invoker cache set nil after the ZK connection is lost Fix: consumer invoker cache set nil after the ZK connection is lost Jan 18, 2021
wenxuwan
wenxuwan reviewed Jan 19, 2021
View reviewed changes
remoting/zookeeper/listener.go Show resolved Hide resolved
remoting/zookeeper/listener.go Outdated Show resolved Hide resolved
remoting/zookeeper/listener.go Outdated Show resolved Hide resolved
@champly
Copy link
Contributor

champly commented Jan 21, 2021

我们也遇到了相同的问题，按照修改已经解决了

champly added a commit to symcn/mosn that referenced this pull request Jan 21, 2021
@champly
fix zk connect is empty bug with:apache/dubbo-go#985
395aee1
@AlexStocks AlexStocks force-pushed the develop branch 2 times, most recently from 25c3b98 to 9a666eb Compare January 23, 2021 11:12
@AlexStocks AlexStocks added this to the v1.5.6 milestone Jan 23, 2021
@cityiron
Copy link
Contributor

You should resolve conflicts, @jack15083 hi, what your name in dingding?

@jack15083
Copy link
Contributor Author

You should resolve conflicts, @jack15083 hi, what your name in dingding?

冲突已经解决了

@cityiron cityiron changed the base branch from develop to 1.5 January 26, 2021 13:54
wenxuwan
wenxuwan reviewed Feb 1, 2021
View reviewed changes
config/reference_config.go Outdated Show resolved Hide resolved
remoting/zookeeper/facade.go Outdated Show resolved Hide resolved
@AlexStocks AlexStocks merged commit 6a63a99 into apache:1.5 Feb 3, 2021
AlexStocks added a commit that referenced this pull request Apr 14, 2021
@AlexStocks
Merge pull request #985 from jack15083/fix_zk_reconnect_issue
4fb9e7c 
Fix: consumer invoker cache set nil after the ZK connection is lost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Patrick0308 Patrick0308 Patrick0308 left review comments

@champly champly champly left review comments

@zouyx zouyx zouyx approved these changes

@AlexStocks AlexStocks AlexStocks approved these changes

@wenxuwan wenxuwan wenxuwan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.6
Development

Successfully merging this pull request may close these issues.
8 participants
@jack15083 @codecov-io @champly @cityiron @zouyx @Patrick0308 @AlexStocks @wenxuwan