Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix router_config add &url to url #910

Merged
merged 1 commit into from
Dec 5, 2020
Merged

Conversation

georgehao
Copy link
Contributor

What this PR does:
fix bug
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

Codecov Report

Merging #910 (8f916e6) into develop (7efba16) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #910      +/-   ##
===========================================
- Coverage    59.90%   59.79%   -0.11%     
===========================================
  Files          260      260              
  Lines        12854    12854              
===========================================
- Hits          7700     7686      -14     
- Misses        4191     4206      +15     
+ Partials       963      962       -1     
Impacted Files Coverage Δ
config/router_config.go 68.18% <100.00%> (ø)
config_center/nacos/facade.go 79.31% <0.00%> (-10.35%) ⬇️
metadata/report/delegate/delegate_report.go 29.66% <0.00%> (-9.33%) ⬇️
config_center/nacos/client.go 65.26% <0.00%> (-2.11%) ⬇️
cluster/cluster_impl/failback_cluster_invoker.go 78.31% <0.00%> (+2.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7efba16...8f916e6. Read the comment docs.

@zouyx zouyx added this to the v1.5.5 milestone Dec 5, 2020
Copy link
Member

@zouyx zouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zouyx zouyx merged commit 68ff8be into apache:develop Dec 5, 2020
@zouyx zouyx self-assigned this Dec 5, 2020
@zouyx zouyx added the bug Something isn't working label Dec 5, 2020
AlexStocks pushed a commit that referenced this pull request Apr 14, 2021
fix: fix router_config add &url to url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants