Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX:#906 #907

Merged
merged 1 commit into from
Dec 4, 2020
Merged

FIX:#906 #907

merged 1 commit into from
Dec 4, 2020

Conversation

wenxuwan
Copy link
Member

@wenxuwan wenxuwan commented Dec 3, 2020

As title, try to fix panic when zk disconnected.

@codecov-io
Copy link

Codecov Report

Merging #907 (ee35594) into develop (2b8aad0) will decrease coverage by 0.32%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #907      +/-   ##
===========================================
- Coverage    60.11%   59.78%   -0.33%     
===========================================
  Files          260      260              
  Lines        12781    12854      +73     
===========================================
+ Hits          7683     7685       +2     
- Misses        4137     4206      +69     
- Partials       961      963       +2     
Impacted Files Coverage Δ
registry/zookeeper/registry.go 50.36% <0.00%> (-1.52%) ⬇️
remoting/getty/readwriter.go 42.85% <0.00%> (-11.43%) ⬇️
metadata/report/delegate/delegate_report.go 29.66% <0.00%> (-10.17%) ⬇️
...tocol/rest/server/server_impl/go_restful_server.go 43.90% <0.00%> (-4.88%) ⬇️
remoting/getty/getty_client.go 41.97% <0.00%> (-4.62%) ⬇️
remoting/getty/listener.go 41.08% <0.00%> (-1.18%) ⬇️
remoting/getty/pool.go 68.72% <0.00%> (-0.89%) ⬇️
protocol/dubbo/impl/hessian.go 29.17% <0.00%> (-0.27%) ⬇️
registry/zookeeper/listener.go 67.16% <0.00%> (+0.49%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b8aad0...ee35594. Read the comment docs.

Copy link
Member

@zouyx zouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which version would you want to fix ? in 1.4.5 or the lastest version? You use 1.4.5

#906

@wenxuwan
Copy link
Member Author

wenxuwan commented Dec 4, 2020

Which version would you want to fix ? in 1.4.5 or the lastest version? You use 1.4.5

#906

common issue, we can merge into develop branch, i use my own branch local which fork from 1.4.5.

@AlexStocks AlexStocks merged commit 7efba16 into apache:develop Dec 4, 2020
AlexStocks added a commit that referenced this pull request Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants