Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: refact heartbeat #889

Merged
merged 5 commits into from
Nov 30, 2020
Merged

Conversation

fangyincheng
Copy link
Contributor

@fangyincheng fangyincheng commented Nov 23, 2020

  • client send heartbeat
    now: close session when once timeout
    doing: close session when three times timeout(60s*3)
  • server send heartbeat
    now: print error when error response
    doing: close session when three times timeout(60s*3)

@fangyincheng fangyincheng changed the title Fix: heartbeat for server->client [WIP] Fix: heartbeat for server->client Nov 23, 2020
remoting/getty/config.go Outdated Show resolved Hide resolved
remoting/getty/config.go Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Nov 24, 2020

Codecov Report

Merging #889 (baea12a) into develop (2c1dc13) will decrease coverage by 0.30%.
The diff coverage is 27.90%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #889      +/-   ##
===========================================
- Coverage    60.15%   59.85%   -0.31%     
===========================================
  Files          260      260              
  Lines        12783    12840      +57     
===========================================
- Hits          7690     7685       -5     
- Misses        4133     4192      +59     
- Partials       960      963       +3     
Impacted Files Coverage Δ
remoting/getty/listener.go 38.18% <15.15%> (-4.08%) ⬇️
remoting/getty/readwriter.go 42.85% <20.00%> (-11.43%) ⬇️
remoting/getty/config.go 13.41% <36.36%> (+3.55%) ⬆️
remoting/getty/getty_server.go 41.96% <50.00%> (ø)
remoting/getty/getty_client.go 49.48% <80.00%> (+2.89%) ⬆️
metadata/report/delegate/delegate_report.go 29.66% <0.00%> (-10.17%) ⬇️
remoting/kubernetes/client.go 72.72% <0.00%> (-6.07%) ⬇️
remoting/kubernetes/listener.go 50.52% <0.00%> (-5.27%) ⬇️
remoting/kubernetes/watch.go 77.17% <0.00%> (-2.18%) ⬇️
remoting/getty/pool.go 69.60% <0.00%> (+0.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c1dc13...7e66fa1. Read the comment docs.

@fangyincheng fangyincheng changed the title [WIP] Fix: heartbeat for server->client [WIP] Fix: refact heartbeat Nov 25, 2020
@fangyincheng fangyincheng changed the title [WIP] Fix: refact heartbeat Fix: refact heartbeat Nov 25, 2020
@zouyx zouyx added this to the v1.5.5 milestone Nov 27, 2020
@AlexStocks AlexStocks merged commit 90a3673 into apache:develop Nov 30, 2020
@fangyincheng fangyincheng deleted the fix-heartbeat branch December 20, 2020 10:39
AlexStocks added a commit that referenced this pull request Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants