Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imp: Correct words and format codes #704

Merged
merged 3 commits into from
Aug 9, 2020
Merged

Imp: Correct words and format codes #704

merged 3 commits into from
Aug 9, 2020

Conversation

Howie59
Copy link
Contributor

@Howie59 Howie59 commented Aug 9, 2020

No description provided.

protocol/dubbo/client.go Outdated Show resolved Hide resolved
protocol/dubbo/codec.go Outdated Show resolved Hide resolved
zouyx
zouyx previously approved these changes Aug 9, 2020
Copy link
Member

@zouyx zouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change target branch to develop pls

@zouyx zouyx dismissed their stale review August 9, 2020 06:23

target branch is wrong

@codecov-commenter
Copy link

Codecov Report

Merging #704 into master will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #704      +/-   ##
==========================================
- Coverage   63.88%   63.77%   -0.12%     
==========================================
  Files         236      236              
  Lines       12313    12313              
==========================================
- Hits         7866     7852      -14     
- Misses       3680     3692      +12     
- Partials      767      769       +2     
Impacted Files Coverage Δ
cluster/loadbalance/consistent_hash.go 90.32% <ø> (ø)
cluster/router/condition/router.go 75.84% <ø> (ø)
protocol/dubbo/client.go 67.87% <ø> (-1.22%) ⬇️
protocol/dubbo/codec.go 72.50% <ø> (ø)
protocol/grpc/server.go 68.42% <ø> (ø)
protocol/result.go 0.00% <ø> (ø)
registry/etcdv3/service_discovery.go 16.54% <ø> (ø)
registry/nacos/listener.go 80.00% <ø> (ø)
remoting/etcdv3/client.go 51.51% <ø> (ø)
remoting/kubernetes/registry_controller.go 55.67% <ø> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abcc4df...ecdf8cc. Read the comment docs.

@zouyx zouyx added the enhancement New feature or request label Aug 9, 2020
@zouyx zouyx added this to the 1.5.1 milestone Aug 9, 2020
Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fangyincheng fangyincheng merged commit aaa8be3 into apache:master Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants