Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #139]add failfast. resolve #139 #140

Merged
merged 1 commit into from
Aug 2, 2019

Conversation

xujianhai666
Copy link
Member

What this PR does:
add failfastClusterInvoker

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

codecov-io commented Jul 26, 2019

Codecov Report

Merging #140 into master will increase coverage by 0.18%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
+ Coverage   68.33%   68.52%   +0.18%     
==========================================
  Files          69       71       +2     
  Lines        4346     4369      +23     
==========================================
+ Hits         2970     2994      +24     
+ Misses       1074     1072       -2     
- Partials      302      303       +1
Impacted Files Coverage Δ
cluster/cluster_impl/failfast_cluster.go 100% <100%> (ø)
cluster/cluster_impl/failover_cluster_invoker.go 84.61% <100%> (+3.66%) ⬆️
cluster/cluster_impl/failfast_cluster_invoker.go 71.42% <71.42%> (ø)
cluster/cluster_impl/base_cluster_invoker.go 71.69% <80%> (+22.76%) ⬆️
remoting/zookeeper/listener.go 45.94% <0%> (-2.71%) ⬇️
remoting/zookeeper/client.go 63.76% <0%> (-0.58%) ⬇️
config_center/zookeeper/listener.go 86.95% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 887a3f6...40fba78. Read the comment docs.

Copy link
Contributor

@hxmhlt hxmhlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cluster/cluster_impl/failfast_cluster_test.go Outdated Show resolved Hide resolved
cluster/cluster_impl/failfast_cluster_invoker.go Outdated Show resolved Hide resolved
cluster/cluster_impl/base_cluster_invoker.go Outdated Show resolved Hide resolved
protocol/mock_invoker.go Outdated Show resolved Hide resolved
@xujianhai666 xujianhai666 force-pushed the feat-failfast branch 2 times, most recently from a2bd8b9 to 7ad0c6c Compare July 28, 2019 14:48
Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexStocks AlexStocks merged commit 14e1487 into apache:master Aug 2, 2019
LaurenceLiZhixin added a commit to LaurenceLiZhixin/dubbo-go that referenced this pull request Jul 17, 2021
* Fix: change 3.0 streaming test to reactive

* fix: change nacos version

* fix

* Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants