Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix license head file #138

Merged
merged 1 commit into from
Jul 26, 2019

Conversation

wolfstudy
Copy link
Member

Signed-off-by: xiaolong.ran ranxiaolong716@gmail.com

Special notes for your reviewer:

In the following file:

  • cluster/loadbalance/least_active.go
  • cluster/loadbalance/round_robin.go
  • filter/impl/active_filter.go
  • protocol/RpcStatus.go

the license head file as follows:

// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

But in most files, the license head file looks like this:

/*
 * Licensed to the Apache Software Foundation (ASF) under one or more
 * contributor license agreements.  See the NOTICE file distributed with
 * this work for additional information regarding copyright ownership.
 * The ASF licenses this file to You under the Apache License, Version 2.0
 * (the "License"); you may not use this file except in compliance with
 * the License.  You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

To ensure uniformity, we should use the same format of the license head file in the same project.

Another question, should we add a check on the license head file in ci to ensure that all licenses header files submitted by contributors are the same.

Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
@wolfstudy
Copy link
Member Author

@fangyincheng @hxmhlt PTAL thanks.

@codecov-io
Copy link

codecov-io commented Jul 26, 2019

Codecov Report

Merging #138 into master will increase coverage by 0.71%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
+ Coverage   67.64%   68.36%   +0.71%     
==========================================
  Files          69       69              
  Lines        4346     4346              
==========================================
+ Hits         2940     2971      +31     
+ Misses       1104     1073      -31     
  Partials      302      302
Impacted Files Coverage Δ
filter/impl/active_filter.go 18.18% <ø> (ø) ⬆️
cluster/loadbalance/least_active.go 91.3% <ø> (ø) ⬆️
cluster/loadbalance/round_robin.go 88.7% <ø> (ø) ⬆️
cluster/cluster_impl/base_cluster_invoker.go 48.93% <0%> (-19.15%) ⬇️
config_center/zookeeper/listener.go 86.95% <0%> (+4.34%) ⬆️
protocol/dubbo/pool.go 62.01% <0%> (+5.02%) ⬆️
protocol/dubbo/readwriter.go 72.97% <0%> (+5.4%) ⬆️
protocol/dubbo/codec.go 77.14% <0%> (+8.57%) ⬆️
protocol/dubbo/listener.go 64.22% <0%> (+10.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f0abe3...b95ea52. Read the comment docs.

@AlexStocks AlexStocks merged commit 414bb0c into apache:master Jul 26, 2019
LaurenceLiZhixin added a commit to LaurenceLiZhixin/dubbo-go that referenced this pull request Jul 17, 2021
* fix: updata go get dubbo-gen script

* fix

* fix: add etcd test

* fix: add msgpack sample

* fix

* fix

* fix: fix conflict

* fix: add test

* Fix: split import block

* fix: delete unused block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants