bug fix for UnregisterEvent #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexStocks
reviewed
Jul 15, 2019
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
==========================================
- Coverage 68.59% 68.56% -0.04%
==========================================
Files 69 69
Lines 4347 4346 -1
==========================================
- Hits 2982 2980 -2
Misses 1064 1064
- Partials 301 302 +1
Continue to review full report at Codecov.
|
gaoxinge
reviewed
Jul 16, 2019
LaurenceLiZhixin
pushed a commit
to LaurenceLiZhixin/dubbo-go
that referenced
this pull request
Jul 17, 2021
* add general .run file * add .run xml * del repeat xml in general folder * mod format xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
将UnregisterEvent函数中的循环去掉，该事件意在删除满足if条件e == event的注册地址，而不是删除整个zkPath对应的注册列表。
原代码中：如果函数中a的长度是2，经过删除长度为1，能继续进入循环，但因为无满足的e == event，无法继续删除，造成死循环。
改动：函数并没有重复检查是否有zkPath的注册信息的必要，删除for循环。
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: