Fix: body buffer too short #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 17, 2021 12:48
…of the body buffer is smaller than the size marked by header
|
would u add an ut for ur pr? |
flycash
reviewed
Mar 18, 2021
remoting/getty/readwriter.go
Outdated
| @@ -114,7 +114,8 @@ func (p *RpcServerPackageHandler) Read(ss getty.Session, data []byte) (interface | |||
| req, length, err := (p.server.codec).Decode(data) | |||
| //resp,len, err := (*p.).DecodeResponse(buf) | |||
| if err != nil { | |||
| if err == hessian.ErrHeaderNotEnough || err == hessian.ErrBodyNotEnough { | |||
| originErr := perrors.Cause(err) | |||
| if originErr == hessian.ErrHeaderNotEnough || originErr == hessian.ErrBodyNotEnough { | |||
AlexStocks
approved these changes
Mar 18, 2021
added 6 commits
March 19, 2021 00:31
Codecov Report
@@ Coverage Diff @@
## 1.5 #1090 +/- ##
==========================================
- Coverage 59.53% 59.10% -0.43%
==========================================
Files 259 269 +10
Lines 12737 13122 +385
==========================================
+ Hits 7583 7756 +173
- Misses 4199 4396 +197
- Partials 955 970 +15
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #1089
Special notes for your reviewer:
Does this PR introduce a user-facing change?: