fix comment.

Signed-off-by: imxyb <xyb4638@gmail.com>
apache · Nov 27, 2019 · f8470a2 · f8470a2
1 parent 7fb327e
commit f8470a2
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 12 deletions.
diff --git a/cluster/loadbalance/consistent_hash.go b/cluster/loadbalance/consistent_hash.go
@@ -26,7 +26,9 @@ import (
 	"sort"
 	"strconv"
 	"strings"
+)
 
+import (
 	"github.com/apache/dubbo-go/cluster"
 	"github.com/apache/dubbo-go/common/constant"
 	"github.com/apache/dubbo-go/common/extension"
@@ -39,17 +41,19 @@ const (
 	HashArguments  = "hash.arguments"
 )
 
-var selectors = make(map[string]*ConsistentHashSelector)
-var re = regexp.MustCompile(constant.COMMA_SPLIT_PATTERN)
+var (
+	selectors = make(map[string]*ConsistentHashSelector)
+	re        = regexp.MustCompile(constant.COMMA_SPLIT_PATTERN)
+)
 
 func init() {
-	extension.SetLoadbalance(ConsistentHash, NewConsistentHash)
+	extension.SetLoadbalance(ConsistentHash, NewConsistentHashLoadBalance)
 }
 
 type ConsistentHashLoadBalance struct {
 }
 
-func NewConsistentHash() cluster.LoadBalance {
+func NewConsistentHashLoadBalance() cluster.LoadBalance {
 	return &ConsistentHashLoadBalance{}
 }
 
@@ -69,7 +73,7 @@ func (lb *ConsistentHashLoadBalance) Select(invokers []protocol.Invoker, invocat
 	hashCode := crc32.ChecksumIEEE(bs)
 	selector, ok := selectors[key]
 	if !ok || selector.hashCode != hashCode {
-		selectors[key] = NewConsistentHashSelector(invokers, methodName, hashCode)
+		selectors[key] = newConsistentHashSelector(invokers, methodName, hashCode)
 		selector = selectors[key]
 	}
 	return selector.Select(invocation)
@@ -97,12 +101,8 @@ type ConsistentHashSelector struct {
 	argumentIndex   []int
 }
 
-func NewConsistentHashSelector(invokers []protocol.Invoker, methodName string,
+func newConsistentHashSelector(invokers []protocol.Invoker, methodName string,
 	hashCode uint32) *ConsistentHashSelector {
-	if len(invokers) == 0 {
-		panic("none of invokers")
-	}
-
 	selector := &ConsistentHashSelector{}
 	selector.virtualInvokers = make(map[uint32]protocol.Invoker)
 	selector.hashCode = hashCode

diff --git a/cluster/loadbalance/consistent_hash_test.go b/cluster/loadbalance/consistent_hash_test.go
@@ -43,7 +43,7 @@ func (s *consistentHashSelectorSuite) SetupTest() {
 	url, _ := common.NewURL(context.TODO(),
 		"dubbo://192.168.1.0:20000/org.apache.demo.HelloService?methods.echo.hash.arguments=0,1")
 	invokers = append(invokers, protocol.NewBaseInvoker(url))
-	s.selector = NewConsistentHashSelector(invokers, "echo", 999944)
+	s.selector = newConsistentHashSelector(invokers, "echo", 999944)
 }
 
 func (s *consistentHashSelectorSuite) TestToKey() {
@@ -92,7 +92,7 @@ func (s *consistentHashLoadBalanceSuite) SetupTest() {
 	s.invoker3 = protocol.NewBaseInvoker(s.url3)
 
 	s.invokers = append(s.invokers, s.invoker1, s.invoker2, s.invoker3)
-	s.lb = NewConsistentHash()
+	s.lb = NewConsistentHashLoadBalance()
 }
 
 func (s *consistentHashLoadBalanceSuite) TestSelect() {