Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vestigal conbench integration #9855

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Mar 29, 2024

Which issue does this PR close?

Part of #5504

Rationale for this change

The arrow monorepo https://github.com/apache/arrow has a nice automated system called conbench that tracks performance. At some point it was partially integrated into DataFusion as part of #1791 but that work was not completed
Now that @gruuya and @Dandandan are working on an alternate strategy (e.g. #9461) we can just get rid of the old vestigal code

What changes are included in this PR?

Remove conbench directory

Are these changes tested?

By CI

Are there any user-facing changes?

No, this is a developer only change

@alamb alamb added the development-process Related to development process of DataFusion label Mar 29, 2024
@github-actions github-actions bot removed the development-process Related to development process of DataFusion label Mar 29, 2024
@gruuya
Copy link
Contributor

gruuya commented Mar 29, 2024

While you're at it do you mind removing the two ./bench.sh run tpch_mem10 lines in the Benchmarks workflow (in relation to #9800 (comment))?

Here
https://github.com/apache/arrow-datafusion/blob/d7957636327fb8d89e6428152492107e39d614b2/.github/workflows/pr_benchmarks.yml#L50
and here
https://github.com/apache/arrow-datafusion/blob/d7957636327fb8d89e6428152492107e39d614b2/.github/workflows/pr_benchmarks.yml#L73

@alamb
Copy link
Contributor Author

alamb commented Mar 29, 2024

While you're at it do you mind removing the two ./bench.sh run tpch_mem10 lines in the Benchmarks workflow (in relation to #9800 (comment))?

#9856

@andygrove
Copy link
Member

Thanks @alamb

@andygrove andygrove merged commit aaad010 into apache:main Mar 29, 2024
24 checks passed
@alamb alamb deleted the alamb/remove_conbench branch March 29, 2024 13:38
Lordworms pushed a commit to Lordworms/arrow-datafusion that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants