Initial support LogicalPlan to SQL String #9596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
alamb
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Thank you @backkem -- this looks (really) nice to me. It is great to establish the pattern and then as people need more features they can contribute more to it.
Note I believe this will logically conflict somewhat with @devinjdangelo 's addition of a unparser feature flag in #9578
| @@ -4487,6 +4490,87 @@ impl TableSource for EmptyTable { | |||
| } | |||
| } | |||
|
|
|||
| #[test] | |||
| fn roundtrip_expr() { | |||
| let tests: Vec<(TableReference, &str, &str)> = vec
alamb
changed the title
This was referenced Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #8661
This is an initial attempt at porting over the LogicalPlan Unparser as described in the tracking ticket.
I took a similar approach to #9517 but moved the tests to
sql::teststo make use of theMockContextProvider. I also took a stab at turning the tests into the roundtrip style (SQL -> Expr/Plan -> SQL) as discussed in the Expr PR.