feat: support LargeList in flatten
#9110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
Weijun-H
changed the title
FixedSizeList in flattenLargeList in flatten
comphead
reviewed
Feb 2, 2024
| @@ -551,7 +551,12 @@ impl BuiltinScalarFunction { | |||
| DataType::List(_) => get_base_type(field.data_type()), | |||
| _ => Ok(data_type.to_owned()), | |||
| }, | |||
| _ => internal_err!("Not reachable, data_type should be List"), | |||
| DataType::LargeList(field) => match field.data_type() { | |||
There was a problem hiding this comment.
we prob can use if guard here?
DataType::LargeList(field) if field.data_type() =>
comphead
reviewed
Feb 2, 2024
| offsets: OffsetBuffer<i32>, | ||
| indexes: OffsetBuffer<i32>, | ||
| ) -> OffsetBuffer<i32> { | ||
| fn get_offsets_for_flatten<O: OffsetSizeTrait>( |
comphead
reviewed
Feb 2, 2024
| let offsets: Vec<i32> = indexes.iter().map(|i| buffer[*i as usize]).collect(); | ||
| let offsets: Vec<O> = indexes | ||
| .iter() | ||
| .map(|i| buffer[i.to_usize().unwrap()]) |
There was a problem hiding this comment.
wondering what is cheaper....
just cast as usize, or to_size and then unwrap
There was a problem hiding this comment.
We cannot cast it as usize directly because *i is OffsetSizeTrait
comphead
reviewed
Feb 2, 2024
| query ??? | ||
| select flatten(make_array(1, 2, 1, 3, 2)), | ||
| flatten(make_array([1], [2, 3], [null], make_array(4, null, 5))), | ||
| flatten(make_array([[1.1]], [[2.2]], [[3.3], [4.4]])); | ||
| ---- | ||
| [1, 2, 1, 3, 2] [1, 2, 3, , 4, , 5] [1.1, 2.2, 3.3, 4.4] | ||
|
|
||
| query ??? |
There was a problem hiding this comment.
please add test description
comphead
reviewed
Feb 2, 2024
| query ???? | ||
| select column1, column2, column3, column4 from flatten_table; | ||
| ---- | ||
| [[1], [2], [3]] [[[1, 2, 3]], [[4, 5]], [[6]]] [[[[1]]], [[[2, 3]]]] [[1.0], [2.1, 2.2], [3.2, 3.3, 3.4]] | ||
| [[1, 2], [3, 4], [5, 6]] [[[8]]] [[[[1, 2]]], [[[3]]]] [[1.0, 2.0], [3.0, 4.0], [5.0, 6.0]] | ||
|
|
||
| query ???? |
There was a problem hiding this comment.
please add test description
comphead
reviewed
Feb 2, 2024
| @@ -5368,6 +5398,16 @@ from flatten_table; | |||
| [1, 2, 3] [1, 2, 3, 4, 5, 6] [1, 2, 3] [1.0, 2.1, 2.2, 3.2, 3.3, 3.4] | |||
| [1, 2, 3, 4, 5, 6] [8] [1, 2, 3] [1.0, 2.0, 3.0, 4.0, 5.0, 6.0] | |||
|
|
|||
| query ???? | |||
comphead
reviewed
Feb 3, 2024
comphead
approved these changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Parts #8185
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?