Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for streaming usecase #9070

Merged
merged 9 commits into from
Jan 31, 2024
Merged

Add documentation for streaming usecase #9070

merged 9 commits into from
Jan 31, 2024

Conversation

mustafasrepo
Copy link
Contributor

Which issue does this PR close?

Improves the situation on epic:#9016
It closes first and second tickets

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Yes

Are there any user-facing changes?

@mustafasrepo
Copy link
Contributor Author

@Tangruilin I had some spare time and decided to work on this issue. Feel free to review this PR, and also add new examples to show capabilities of datafusion.

@Tangruilin
Copy link
Contributor

@Tangruilin I had some spare time and decided to work on this issue. Feel free to review this PR, and also add new examples to show capabilities of datafusion.

Okey, thanks very much for help

Copy link
Contributor

@ozankabak ozankabak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I added some clarifications

docs/source/user-guide/sql/ddl.md Outdated Show resolved Hide resolved
Co-authored-by: Mehmet Ozan Kabak <ozankabak@gmail.com>
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mustafasrepo 🙏 -- this looks great

I left some small suggestions on how to maybe improve it, but I don't think they are required to merge this PR

datafusion/common/src/test_util.rs Outdated Show resolved Hide resolved
datafusion-examples/examples/csv_sql_streaming.rs Outdated Show resolved Hide resolved
datafusion-examples/examples/csv_sql_streaming.rs Outdated Show resolved Hide resolved
datafusion-examples/examples/csv_sql_streaming.rs Outdated Show resolved Hide resolved
@mustafasrepo mustafasrepo merged commit 0414b9f into apache:main Jan 31, 2024
23 checks passed
@alamb
Copy link
Contributor

alamb commented Jan 31, 2024

Love it -- thanks again @mustafasrepo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants