Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue where upper and lower functions only work correctly on ascii character #9054

Merged
merged 1 commit into from
Jan 29, 2024
Merged

fix issue where upper and lower functions only work correctly on ascii character #9054

merged 1 commit into from
Jan 29, 2024

Conversation

Omega359
Copy link
Contributor

Which issue does this PR close?

Closes #9053

Are these changes tested?

Yes, added sql tests with unicode characters

Are there any user-facing changes?

No,

@github-actions github-actions bot added physical-expr Physical Expressions sqllogictest SQL Logic Tests (.slt) labels Jan 29, 2024
@alamb alamb mentioned this pull request Jan 29, 2024
Closed
6 tasks
alamb
alamb approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Omega359 -- 🙏

@alamb alamb merged commit 8326f57 into apache:main Jan 29, 2024
22 checks passed
@Omega359 Omega359 deleted the bug/upper_lower_9053 branch January 31, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
physical-expr Physical Expressions sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

upper and lower functions only work correctly on ascii characters
2 participants
@Omega359 @alamb