Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: small updates to bench.sh #9035

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Minor: small updates to bench.sh #9035

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions benchmarks/bench.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
Expand Down Expand Up @@ -53,14 +53,14 @@ Examples:
./bench.sh data

# Run the 'tpch' benchmark on the datafusion checkout in /source/arrow-datafusion
DATAFASION_DIR=/source/arrow-datafusion ./bench.sh run tpch
DATAFUSION_DIR=/source/arrow-datafusion ./bench.sh run tpch

**********
* Commands
**********
data: Generates data needed for benchmarking
data: Generates or downloads data needed for benchmarking
run: Runs the named benchmark
compare: Comares results from benchmark runs
compare: Compares results from benchmark runs

**********
* Benchmarks
Expand All @@ -81,7 +81,7 @@ clickbench_extended: ClickBench "inspired" queries against a single parquet (
**********
DATA_DIR directory to store datasets
CARGO_COMMAND command that runs the benchmark binary
DATAFASION_DIR directory to use (default $DATAFUSION_DIR)
DATAFUSION_DIR directory to use (default $DATAFUSION_DIR)
"
exit 1
}
Expand Down Expand Up @@ -239,6 +239,9 @@ main() {
BRANCH2=$2
compare_benchmarks
;;
"")
usage
;;
*)
echo "Error: unknown command: $COMMAND"
usage
Expand Down Expand Up @@ -401,9 +404,9 @@ run_clickbench_1() {
$CARGO_COMMAND --bin dfbench -- clickbench --iterations 5 --path "${DATA_DIR}/hits.parquet" --queries-path "${SCRIPT_DIR}/queries/clickbench/queries.sql" -o ${RESULTS_FILE}
}

# Runs the clickbench benchmark with a single large parquet file
# Runs the clickbench benchmark with the partitioned parquet files
run_clickbench_partitioned() {
RESULTS_FILE="${RESULTS_DIR}/clickbench_1.json"
RESULTS_FILE="${RESULTS_DIR}/clickbench_partitioned.json"
echo "RESULTS_FILE: ${RESULTS_FILE}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

echo "Running clickbench (partitioned, 100 files) benchmark..."
$CARGO_COMMAND --bin dfbench -- clickbench --iterations 5 --path "${DATA_DIR}/hits_partitioned" --queries-path "${SCRIPT_DIR}/queries/clickbench/queries.sql" -o ${RESULTS_FILE}
Expand Down
Loading