Minor: fix: #9010 - Optimizer schema change assert error is incorrect #9012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curtisleefulton
changed the title
9 tasks
alamb
approved these changes
Jan 26, 2024
| @@ -294,7 +294,7 @@ impl Optimizer { | |||
| self.optimize_recursively(rule, &new_plan, config) | |||
| .and_then(|plan| { | |||
| if let Some(plan) = &plan { | |||
| assert_schema_is_the_same(rule.name(), &new_plan, plan)?; | |||
| assert_schema_is_the_same(rule.name(), plan, &new_plan)?; | |||
There was a problem hiding this comment.
alamb
changed the title
|
Thanks @curtisleefulton ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This is one-line fix: The assert_schema_is_the_same error will now report prev_plan / new_plan in the correct order.
Closes #9010.
Rationale for this change
When debugging logical plan optimization change errors, it's important to know the correct values of prev_plan / new_plan so further investigation is can move quickly.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
No. This change will not affect the API.
No. This change will not affect the API.