Add support for Postgres LIKE operators #8894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
|
UPDATE: ready for review since the sqlparser PR got merged. |
gruuya
force-pushed
the
pg-like-operators
branch
from
2500eae
to
f4a7f9c
Compare
gruuya
force-pushed
the
pg-like-operators
branch
from
ba25339
to
d2717ba
Compare
9 tasks
alamb
approved these changes
Jan 25, 2024
Cargo.toml
Outdated
| @@ -70,7 +70,7 @@ parquet = { version = "50.0.0", default-features = false, features = ["arrow", " | |||
| rand = "0.8" | |||
| rstest = "0.18.0" | |||
| serde_json = "1" | |||
| sqlparser = { version = "0.41.0", features = ["visitor"] } | |||
| sqlparser = { git = "https://github.com/sqlparser-rs/sqlparser-rs", rev = "c7d2903c6d1d1a98e6e6203c5cfd54acb9aeca16", features = ["visitor"] } | |||
There was a problem hiding this comment.
I think we need to wait for sqlparser to be released -- see apache/datafusion-sqlparser-rs#1074 prior to merging this. However I plan to work on releasing sqlparser later today so I think we should be good shortly
There was a problem hiding this comment.
Thanks, that was quick!
I've merged the latest main into this branch now, let me know if there's anything else to do.
| @@ -263,6 +263,58 @@ Not Regex Case-Insensitive Match | |||
| +---------------------------------------------------+ | |||
| ``` | |||
|
|
|||
| ### `~~` | |||
|
#9000 has the sqlparser upgrade |
gruuya
force-pushed
the
pg-like-operators
branch
from
1de01f2
to
e11a26b
Compare
alamb
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8893.
Rationale for this change
Add support for Postgres
~~,~~*,!~~,!~~*like-pattern operators, in analogy with the regex-matching operators~,~*,!~,!~*.What changes are included in this PR?
Extend the
Operatorenum with the new variants, and wire-up evaluation for them.Are these changes tested?
Yes.
Are there any user-facing changes?
New operators available to be used in querying.