Add note on using larger row group size #8745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jan 4, 2024
9 tasks
|
I took the liberty of pushing a a commit to fix the CI failures |
github-actions
bot
removed
the
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
It adds a note on the larger row group sizes as discussed here. #7675 (reply in thread)
Rationale for this change
Row group size changes the memory usage of a query. Reading and writing larger row groups requires more memory.
This should be called out in the docs. Currently I've mentioned.
What changes are included in this PR?
Same as title
Are these changes tested?
Only added extra explanation to doc
Are there any user-facing changes?
Only added extra explanation to doc