Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Antarctica/Vostok tz offset changed in chrono-tz 0.8.5 #8677

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

korowa
Copy link
Contributor

@korowa korowa commented Dec 29, 2023

Which issue does this PR close?

Closes --.

Rationale for this change

What changes are included in this PR?

Due to recently changed Antarctica/Vostok tz offset (see commit which also affected fresh chrono-tz 0.8.5 release) the test with this tz started failing.

In order not to affect existsing 0.8.4 chono-tz on someones machine, and successfully complete all tests on github runners -- the suggestion is to just delete this tz from test (I suppose three cases will be enought for testing string TZ parsing).

Are these changes tested?

Only tests has been modified

Are there any user-facing changes?

No

@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Dec 29, 2023
@korowa korowa changed the title minor: remove tz with modified offset from tests fix: remove tz with modified offset from tests Dec 29, 2023
@korowa korowa changed the title fix: remove tz with modified offset from tests fix: Antarctica/Vostok tz offset changed in chrono-tz 0.8.5 Dec 29, 2023
Copy link
Contributor

@ozankabak ozankabak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@ozankabak ozankabak merged commit 8ced56e into apache:main Dec 29, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants