Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move parquet_schema.rs from sql to parquet tests #8644

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Move parquet_schema.rs from sql to parquet tests #8644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions datafusion/core/tests/parquet/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ mod file_statistics;
mod filter_pushdown;
mod page_pruning;
mod row_group_pruning;
mod schema;
mod schema_coercion;

#[cfg(test)]
Expand Down
17 changes: 15 additions & 2 deletions datafusion/core/tests/sql/parquet_schema.rs → datafusion/core/tests/parquet/schema.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ use ::parquet::arrow::ArrowWriter;
use tempfile::TempDir;

use super::*;
use datafusion_common::assert_batches_sorted_eq;

#[tokio::test]
async fn schema_merge_ignores_metadata_by_default() {
Expand Down Expand Up @@ -90,7 +91,13 @@ async fn schema_merge_ignores_metadata_by_default() {
.await
.unwrap();

let actual = execute_to_batches(&ctx, "SELECT * from t").await;
let actual = ctx
.sql("SELECT * from t")
.await
.unwrap()
.collect()
.await
.unwrap();
assert_batches_sorted_eq!(expected, &actual);
assert_no_metadata(&actual);
}
Expand Down Expand Up @@ -151,7 +158,13 @@ async fn schema_merge_can_preserve_metadata() {
.await
.unwrap();

let actual = execute_to_batches(&ctx, "SELECT * from t").await;
let actual = ctx
.sql("SELECT * from t")
.await
.unwrap()
.collect()
.await
.unwrap();
assert_batches_sorted_eq!(expected, &actual);
assert_metadata(&actual, &expected_metadata);
}
Expand Down
1 change: 0 additions & 1 deletion datafusion/core/tests/sql/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ pub mod expr;
pub mod group_by;
pub mod joins;
pub mod order;
pub mod parquet_schema;
pub mod partitioned_csv;
pub mod predicates;
pub mod references;
Expand Down