Add metrics for UnnestExec #8482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonvandel
force-pushed
the
add-unnest-exec-metrics
branch
from
2b3f19e
to
b332399
Compare
simonvandel
force-pushed
the
add-unnest-exec-metrics
branch
from
b332399
to
8c9f89e
Compare
8 tasks
alamb
reviewed
Dec 12, 2023
There was a problem hiding this comment.
Thank you for this contributuion @simonvandel -- very nice 👍
| let formatted = arrow::util::pretty::pretty_format_batches(&results) | ||
| .unwrap() | ||
| .to_string(); | ||
| assert_contains!(&formatted, "elapsed_compute="); |
| } | ||
|
|
||
| #[derive(Clone, Debug)] | ||
| struct UnnestMetrics { |
There was a problem hiding this comment.
This has some overlap with BaselineMetrics, it might be able to be combined if you wanted to reduce the code size somewhat
https://docs.rs/datafusion/latest/datafusion/physical_plan/metrics/struct.BaselineMetrics.html
| self.num_output_batches, | ||
| self.num_output_rows, | ||
| self.unnest_time, | ||
| produced {} output batches containing {} rows in {}", |
alamb
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8481.
Rationale for this change
See #8481
What changes are included in this PR?
Adds a new
UnnestMetricsstruct to collect metrics.Are these changes tested?
Yes, added a DF test.
I'm not sure if there are better places to have this kind of test.
I saw that there are similar explain-tests for SQL. However, unnest is not yet implemented for SQL.
Are there any user-facing changes?
Yes, additional metrics now show up in
EXPLAIN ANALYZEqueries.