Refactors on TreeNode Implementations #8395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
8 tasks
alamb
approved these changes
Dec 1, 2023
appletreeisyellow
pushed a commit
to appletreeisyellow/datafusion
that referenced
this pull request
Dec 14, 2023
* minor changes * PipelineStatePropagator tree refactor * Remove duplications by children_unbounded() * Remove on-the-fly tree construction * Minor changes --------- Co-authored-by: Mustafa Akur <mustafa.akur@synnada.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Implementations in 3 places where
TreeNodeis used can be made more useful and understandable. This PR provides these refactorings. The approach inmap_children(), where each node creates its own children and then propagates them, does not fit the patterns very well. In fact, beforemap_children()orapply_children()is called, there isn’t a tree available.What changes are included in this PR?
Instead, we generate the entire tree with empty states using the trees'
new()method. Each node now has its own child nodes initially. All transform operations are handled within the main transformer functions, andmap_children()is only used to provide recursiveness.Are these changes tested?
Covered by existing tests.
Are there any user-facing changes?