Improve numerice_coercion and reuse in both compare op and math op #8385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
jayzhan211
force-pushed
the
fix-numeric-coercion
branch
from
8506795
to
0f6e235
Compare
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
jayzhan211
changed the title
pub
jayzhan211
changed the title
|
Thanks @jayzhan211 -- I think this PR needs some careful review to ensure it doesn't introduce subtle bugs / logic errors. I will try and find time but I worry about this PR introducing regressions for no (practical) benefit. Could you please:
Thank you |
|
If I remember correctly, we currently do not support float16, so it's challenging for us to test these scenarios. |
yes, f16 is not fully support in arrow-rs, so I did not add test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Ref #8302
Rationale for this change
Some type coercion seems incorrect for me, and f16 is not considered.
Something like, but not only
To differentiate the current possible lossy
numeric_coercion. I think it might be helpful somewhere, but keep ittodo!()until we need it.What changes are included in this PR?
Are these changes tested?
Since arrow-rs does not support f16 yet, I didn't add test for f16, just ensure the existing test does not fail.
Add math op coercion in slt. some test is not possible to move to slt yet, so keep it there.
Are there any user-facing changes?
additional context
Decimal coercion is different in compare op and math op. Not sure if we can have common coercion for them.