Minor: Split equivalence code into smaller modules #8235
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
alamb
commented
Nov 16, 2023
| @@ -0,0 +1,488 @@ | |||
| // Licensed to the Apache Software Foundation (ASF) under one | |||
There was a problem hiding this comment.
This code was simply moved around, no algorithmic changes were made
alamb
changed the title
|
Thanks for this. I agree that it is a good idea. One minor timing issue: @mustafasrepo is currently working on a few finishing touches to this code, so doing this next week will probably (1) enable us to see the full picture before doing the re-org, (2) save us some time by avoiding merge conflicts |
|
Sounds good -- I'll leave this as a draft until @mustafasrepo 's in flight work |
|
Now that the new code has been merged, I think this is possible now. However, I don't think I can salvage this PR -- it would make more sense to start from scratch |
|
Field #8633 to track doing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #8064
Rationale for this change
As equivalence and ordering become ever more important, I would like to break the code up into smaller modules to make it harder to handle.
At almost 3000 lines with several large classes that are overlapping. the existing
equivalence.rsis hard to understand.I would like to break it up into smaller modules.
In fact I didn't even realize there were so many equivalence tracking structures until I started looking at the code more closely.
What changes are included in this PR?
Move
EquivalenceClass,EquivalenceGroup,OrderingEquivalenceClass,ProjectionMapping,EquivalenceProperties;and into their own modules, and then update some internal apis to keep the interfaces clearAre these changes tested?
Are there any user-facing changes?
Existing tests