Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI failures on to_timestamp() calls #7941

Merged
merged 10 commits into from
Oct 26, 2023
Merged

Fix CI failures on to_timestamp() calls #7941

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
fdc4128
Change input for `to_timestamp` function
comphead Oct 17, 2023
68a2f76
docs
comphead Oct 17, 2023
830a4c8
fix examples
comphead Oct 17, 2023
5fe44db
output `to_timestamp` signature as ns
comphead Oct 20, 2023
871fd11
Merge branch 'apache:main' into dev
comphead Oct 26, 2023
d3b1139
Fix CI `to_timestamp()` failed
comphead Oct 26, 2023
1f29571
Update datafusion/expr/src/built_in_function.rs
comphead Oct 26, 2023
0325685
fix typo
alamb Oct 26, 2023
d858652
fix
comphead Oct 26, 2023
532351f
Merge branch 'dev' of https://github.com/comphead/arrow-datafusion in…
comphead Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion datafusion/expr/src/built_in_function.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -755,7 +755,10 @@ impl BuiltinScalarFunction {
return plan_err!("The to_hex function can only accept integers.");
}
}),
BuiltinScalarFunction::ToTimestamp => Ok(Timestamp(Nanosecond, None)),
BuiltinScalarFunction::ToTimestamp => Ok(match &input_expr_types[0] {
Int64 => Timestamp(Second, None),
_ => Timestamp(Nanosecond, None),
}),
BuiltinScalarFunction::ToTimestampMillis => Ok(Timestamp(Millisecond, None)),
BuiltinScalarFunction::ToTimestampMicros => Ok(Timestamp(Microsecond, None)),
BuiltinScalarFunction::ToTimestampNanos => Ok(Timestamp(Nanosecond, None)),
Expand Down