Maintain time zone in ScalarValue::new_list
#7899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dandandan
force-pushed
the
maintain_time_zone
branch
from
8f81403
to
9dbddbd
Compare
Weijun-H
approved these changes
Oct 22, 2023
Dandandan
changed the title
ScalarValue::new_listScalarValue::new_list
crepererum
reviewed
Oct 23, 2023
| let s: &'static str = "UTC"; | ||
| let values = vec![ScalarValue::TimestampMillisecond(Some(1), Some(s.into()))]; | ||
| let arr = ScalarValue::new_list( | ||
| &values, |
There was a problem hiding this comment.
Does this fail if the timezone provided by one of the values is different than the one provided by the datatype argument?
There was a problem hiding this comment.
Yes, the test fails (and test as is fails on master).
crepererum
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7900
Rationale for this change
This causes some bugs in Coralogix for
count distinct(I couldn't reproduce with sql e2e tests in DataFusion)What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?