Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add section on supports_filters_pushdown #7680

Merged
merged 4 commits into from
Sep 29, 2023

Conversation

tshauck
Copy link
Contributor

@tshauck tshauck commented Sep 28, 2023

Which issue does this PR close?

Closes #7676

Rationale for this change

See issue re: question

What changes are included in this PR?

Adds section to expand on the TableProvider trait functionality and specifically one on supports_filters_pushdown.

Are these changes tested?

image

@tshauck tshauck marked this pull request as ready for review September 28, 2023 04:14
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tshauck !

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tshauck ❤️

docs/source/library-user-guide/custom-table-providers.md Outdated Show resolved Hide resolved
tshauck and others added 2 commits September 28, 2023 12:25
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
@alamb alamb merged commit 6ed2e84 into apache:main Sep 29, 2023
4 checks passed
@alamb
Copy link
Contributor

alamb commented Sep 29, 2023

Thanks again @tshauck and @andygrove

Ted-Jiang pushed a commit to Ted-Jiang/arrow-datafusion that referenced this pull request Oct 7, 2023
* docs: add section on supports_filters_pushdown

* fix: fixup code

* Apply suggestions from code review

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>

* fix: apply prettier

---------

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Custom Table Provider guide should discuss supports_filters_pushdown
3 participants