Minor: consolidate GroupByOrderMode::None
#7150
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #7129
Rationale for this change
Inspired by @mustafasrepo 's comment https://github.com/apache/arrow-datafusion/pull/7129/files#r1278576304 about
Option<GroupByOrderMode>
being redundant withGroupByOrderMode::None
here I tried the alternate approach to see what it would look likeI am not sure which I prefer but figured I would put it up for review in case other people liked this
What changes are included in this PR?
Option<GroupByOrderMode>
toGroupByOrderMode
Are these changes tested?
Covered by existing tests
Are there any user-facing changes?
No