Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: consolidate GroupByOrderMode::None #7150

Closed
wants to merge 2 commits into from

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jul 31, 2023

Which issue does this PR close?

Related to #7129

Rationale for this change

Inspired by @mustafasrepo 's comment https://github.com/apache/arrow-datafusion/pull/7129/files#r1278576304 about Option<GroupByOrderMode> being redundant with GroupByOrderMode::None here I tried the alternate approach to see what it would look like

I am not sure which I prefer but figured I would put it up for review in case other people liked this

What changes are included in this PR?

  1. Change Option<GroupByOrderMode> to GroupByOrderMode

Are these changes tested?

Covered by existing tests

Are there any user-facing changes?

No

@alamb alamb marked this pull request as ready for review July 31, 2023 12:16
@github-actions github-actions bot added the core Core DataFusion crate label Jul 31, 2023
@alamb alamb marked this pull request as draft July 31, 2023 20:50
@alamb alamb closed this Jul 31, 2023
@mustafasrepo
Copy link
Contributor

I think we could have pursued, this approach. Do you think that this is not a good change?

@alamb
Copy link
Contributor Author

alamb commented Aug 1, 2023

I think we could have pursued, this approach. Do you think that this is not a good change?

Sorry I should have been more explicit. Basically I closed it because

  1. It was going to conflict with [bug]: Fix multi partition wrong column requirement bug  #7129
  2. While I prefer this approach rather than Option I think that was just a personal preference and I don't think there is any technical reason to prefer Option vs the approach in this PR.
  3. I was running out of time yesterday and was feeling overwhelmed by too many other open threads of thought to pursue this one

So I do think it is a good change but not valuable enough that I plan to pursue at this time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants