Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (another) logical conflict #6882

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jul 7, 2023

Which issue does this PR close?

Rationale for this change

Fix a logical conflict from #6726

Ci is failing on main like this: https://github.com/apache/arrow-datafusion/actions/runs/5486691970/jobs/9997114358

rror[E0433]: failed to resolve: use of undeclared type `DisplayFormatType`
   --> datafusion/core/src/physical_plan/streaming.rs:105:13
    |
105 |             DisplayFormatType::Default | DisplayFormatType::Verbose => {
    |             ^^^^^^^^^^^^^^^^^ use of undeclared type `DisplayFormatType`

error[E0433]: failed to resolve: use of undeclared type `DisplayFormatType`
   --> datafusion/core/src/physical_plan/streaming.rs:105:42
    |
105 |             DisplayFormatType::Default | DisplayFormatType::Verbose => {
    |                                          ^^^^^^^^^^^^^^^^^ use of undeclared type `DisplayFormatType`

error[E0412]: cannot find type `DisplayFormatType` in this scope
   --> datafusion/core/src/physical_plan/streaming.rs:101:12
    |
101 |         t: DisplayFormatType,
    |            ^^^^^^^^^^^^^^^^^ not found in this scope
    |
help: consider importing this enum
    |
20  + use crate::physical_plan::DisplayFormatType;
    |

error[E0425]: cannot find function, tuple struct or tuple variant `ProjectSchemaDisplay` in this scope
   --> datafusion/core/src/physical_plan/streaming.rs:115:25
    |
115 |                         ProjectSchemaDisplay(&self.projected_schema)
    |                         ^^^^^^^^^^^^^^^^^^^^ not found in this scope
    |
help: consider importing this tuple struct
    |
20  + use crate::datasource::physical_plan::ProjectSchemaDisplay;
    |

error[E0425]: cannot find function, tuple struct or tuple variant `OutputOrderingDisplay` in this scope
   --> datafusion/core/src/physical_plan/streaming.rs:129:33
    |
129 | ...                   OutputOrderingDisplay(ordering)
    |                       ^^^^^^^^^^^^^^^^^^^^^ not found in this scope
    |
help: consider importing this tuple struct
    |
20  + use crate::datasource::physical_plan::OutputOrderingDisplay;
    |

What changes are included in this PR?

Add necessary includes

Are these changes tested?

CI

Are there any user-facing changes?

@github-actions github-actions bot added the core Core DataFusion crate label Jul 7, 2023
@alamb alamb merged commit 55eaa96 into apache:main Jul 7, 2023
20 checks passed
alamb added a commit to alamb/datafusion that referenced this pull request Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant