Return error when internal multiplication overflowing in decimal division kernel #6833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
alamb
approved these changes
Jul 5, 2023
There was a problem hiding this comment.
The code does what the PR says it does 👍
I defer to you (or maybe @liukun4515 ) for if this is the desired behavior
| statement ok | ||
| insert into foo VALUES (1, 5); | ||
|
|
||
| query error DataFusion error: Arrow error: Compute error: Overflow happened on: 100000000000000000000 \* 100000000000000000000000000000000000000 |
There was a problem hiding this comment.
FWIW this is what postgres does (treats it like a float, I think):
postgres=# create table foo (a DECIMAL(38, 20), b DECIMAL(38, 0));
CREATE TABLE
postgres=# insert into foo VALUES (1, 5);
INSERT 0 1
postgres=# select a / b from foo;
?column?
------------------------
0.20000000000000000000
(1 row)
|
Thanks @alamb . Before we can return more correct result for the case, we should return error instead of incorrect result as reported in the issue. That is the purpose of this PR. |
alamb
pushed a commit
to alamb/datafusion
that referenced
this pull request
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related #6794.
Rationale for this change
Before we figure a proper way to address the issue, we should return error for the overflowing case instead of returning incorrect result.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?