Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL planning benchmarks for very wide tables #5256

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Feb 11, 2023

Which issue does this PR close?

Related to `

Add test case for (even larger) tables:

To run:

cargo bench --bench sql_planner

Rationale for this change

There is substantial overhead even without any sophistication. Let's get a microbenchmark up for that

What changes are included in this PR?

  1. Add a benchmark based on code from @zeodtr in Optimizer is slow: Avoid too many string cloning in the optimizer #5157
  2. Update the planning code to be clearer about what it is doing

Are these changes tested?

Not really (they are benchmarking code)

Are there any user-facing changes?

No

Example output

@github-actions github-actions bot added the core Core DataFusion crate label Feb 11, 2023
@alamb alamb changed the title Add planner benchmarks for very wide tables SQL planning benchmarks for very wide tables Feb 11, 2023
@alamb alamb merged commit 07ae738 into apache:master Feb 15, 2023
@ursabot
Copy link

ursabot commented Feb 15, 2023

Benchmark runs are scheduled for baseline = 253550c and contender = 07ae738. 07ae738 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

jiangzhx pushed a commit to jiangzhx/arrow-datafusion that referenced this pull request Feb 24, 2023
@alamb alamb deleted the alamb/sql_planner_bench branch July 26, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants