Clarify documentation on ArrowBytesMap and ArrowBytesViewMap #12789
+6
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
dmitrybugakov
approved these changes
Oct 8, 2024
jonahgao
approved these changes
Oct 9, 2024
|
Thank you @dmitrybugakov and @jonahgao |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #12701
Rationale for this change
While working on #12701 with @dmitrybugakov I realized that the difference between a normal hashbrown map and the
ArrowBytesMapwas not as explicit as it could be, which I think resulted in a bunch of unecessary workWhat changes are included in this PR?
ArrowBytesMapis better than a normal hashsetAre these changes tested?
Yes, by CI
Are there any user-facing changes?
Just docs