Chore: Move aggregate statistics optimizer test from core to optimizer crate
#12783
+388
−338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
jayzhan211
changed the title
aggregate statistics optimizer test from core to optimizer crateaggregate statistics optimizer test from core to optimizer crate
…egate-statistic-test
alamb
approved these changes
Oct 8, 2024
| datafusion-physical-expr = { workspace = true } | ||
| datafusion-physical-plan = { workspace = true } | ||
| itertools = { workspace = true } | ||
|
|
||
| [dev-dependencies] | ||
| datafusion-functions-aggregate = { workspace = true } |
There was a problem hiding this comment.
Would it be possible to avoid this dependency? (I think we could remove it as a follow on PR, but I didn't quite understand why it was needed in the first place)
Looks like it is just count_udaf (which we could perhaps mock up) 🤔
There was a problem hiding this comment.
I think we can't use function that hasn't implement accumulator here, for physical optimizer, I think we should use the real function
Error if I switch to stub
test aggregate_statistics::tests::test_count_partial_with_nulls_indirect_child ... FAILED
test aggregate_statistics::tests::test_count_partial_direct_child ... FAILED
test aggregate_statistics::tests::test_count_partial_with_nulls_direct_child ... FAILED
test aggregate_statistics::tests::test_count_partial_indirect_child ... FAILED
test aggregate_statistics::tests::test_count_inexact_stat ... FAILED
test aggregate_statistics::tests::test_count_with_nulls_inexact_stat ... FAILED
successes:
successes:
failures:
---- aggregate_statistics::tests::test_count_partial_with_nulls_indirect_child stdout ----
Error: NotImplemented("no impl for stub")
---- aggregate_statistics::tests::test_count_partial_direct_child stdout ----
Error: NotImplemented("no impl for stub")
---- aggregate_statistics::tests::test_count_partial_with_nulls_direct_child stdout ----
Error: NotImplemented("no impl for stub")
---- aggregate_statistics::tests::test_count_partial_indirect_child stdout ----
Error: NotImplemented("no impl for stub")
---- aggregate_statistics::tests::test_count_inexact_stat stdout ----
Error: NotImplemented("no impl for stub")
---- aggregate_statistics::tests::test_count_with_nulls_inexact_stat stdout ----
Error: NotImplemented("no impl for stub")
…egate-statistic-test
|
Thanks @alamb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Part of #11502
When we move the file, there is dependency issue that we keep it in core crate before. Now we move it to the ideal place.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?