Dynamic filter pushdown to probe side #12781
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
|
still in draft, similar to DuckDB what does, support single column less than and greater than to push to probe side. Gonna add benchmark test and more test cases later this week. |
Lordworms
commented
Oct 7, 2024
| Some(Ok(batch)) => { | ||
| Some(Ok(mut batch)) => { | ||
| if let Some(dynamic_filters) = &mut self.dynamic_filter_info { | ||
| batch = dynamic_filters.filter_batch(&batch)?; |
There was a problem hiding this comment.
I add the filter logic here, don't know if it is a good choice compare to adding a FilterExec down to scan.
Dandandan
reviewed
Oct 8, 2024
| final_expr: Option<Arc<dyn PhysicalExpr>>, | ||
| } | ||
|
|
||
| impl PhysicalDynamicFiltersInfo { |
There was a problem hiding this comment.
Suggested change
| impl PhysicalDynamicFiltersInfo { | |
| impl PhysicalDynamicFilters { |
?
Dandandan
reviewed
Oct 8, 2024
| let mut new_filter_expr: Option<Arc<dyn PhysicalExpr>> = None; | ||
|
|
||
| for (i, col) in self.probe_side_columns.iter().enumerate() { | ||
| let min_value = self.aggregates[i].evaluate(records)?; |
There was a problem hiding this comment.
Hm... I think you want this be evaluated on other side of the join once (after loading the build side) and then be passed on to the other side.
Now the filter seems to be created from the probe side and the filter is evaluated from probe side?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7955
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?