Parquet binary #12777
Draft
Parquet binary #12777
+55
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
github-actions
bot
added
logical-expr
jayzhan211
commented
Oct 6, 2024
| }; | ||
| fields.push(f); | ||
| } | ||
| let table_schema = Arc::new(arrow_schema::Schema::new(fields)); |
There was a problem hiding this comment.
Change the table schema to utf8
jayzhan211
commented
Oct 6, 2024
|
|
||
| fields.push(f); | ||
| } | ||
| let schema = Schema::new_with_metadata(fields, schema.metadata().clone()); |
There was a problem hiding this comment.
We also need to change the one in logical plan too
alamb
reviewed
Oct 7, 2024
| @@ -231,7 +231,14 @@ impl FileScanConfig { | |||
| for idx in proj_iter { | |||
| if idx < self.file_schema.fields().len() { | |||
| let field = self.file_schema.field(idx); | |||
| table_fields.push(field.clone()); | |||
|
|
|||
| let f = if field.data_type().equals_datatype(&DataType::Binary) { | |||
There was a problem hiding this comment.
If this works out I think we should put this feature behind a feature flag. I think this change will have the effect of changing all binary columns to utf8. This is the right thing to do for the hits_partitioned dataset, but I am not sure it is the right thing to do in general.
I tried to write this up more coeherently in #12788
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?