Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move equivalence fuzz testing to fuzz test binary #12767

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Oct 4, 2024

Which issue does this PR close?

Part of #12700

Rationale for this change

These two tests are fuzz tests and they take 3 orders of magnitude more time to run than the rest of the tests in datafusion-physical-expr

You can see this with

cargo nextest run -p datafusion-physical-expr --lib
        PASS [   0.004s] datafusion-physical-expr window::window_expr::tests::test_is_row_ahead
        PASS [   3.604s] datafusion-physical-expr equivalence::ordering::tests::test_ordering_satisfy_with_equivalence_complex_random
        PASS [   4.350s] datafusion-physical-expr equivalence::properties::tests::test_find_longest_permutation_random
        PASS [  15.111s] datafusion-physical-expr equivalence::projection::tests::ordering_satisfy_after_projection_random

Let's move the fuzz testing to the fuzz test binary to make normal testing faster

What changes are included in this PR?

  1. Move equivalence fuzz testing to fuzz test binary

After this change the entire test suite in phsyical expr runs in less than a second

     Summary [   0.565s] 1327 tests run: 1327 passed, 5 skipped

Are these changes tested?

Yes

Are there any user-facing changes?

No this is entirely development process

@alamb alamb added the development-process Related to development process of DataFusion label Oct 4, 2024
@github-actions github-actions bot added physical-expr Physical Expressions core Core DataFusion crate and removed development-process Related to development process of DataFusion labels Oct 4, 2024
@alamb alamb marked this pull request as ready for review October 7, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate physical-expr Physical Expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant