Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pr_benchmarks.yml #11165

Merged
merged 1 commit into from
Jun 29, 2024
Merged

Remove pr_benchmarks.yml #11165

merged 1 commit into from
Jun 29, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jun 28, 2024

Which issue does this PR close?

N/A

Rationale for this change

The performance variability of the github runners makes running benchmarks on them of questionable value. This may also be a security risk.

What changes are included in this PR?

Remove the github action that runs benchmarks

I couldn't find any documentation about this command so I don't think there is any document to update

Are these changes tested?

Are there any user-facing changes?

@alamb alamb added the development-process Related to development process of DataFusion label Jun 28, 2024
@alamb alamb marked this pull request as ready for review June 28, 2024 14:38
@github-actions github-actions bot removed the development-process Related to development process of DataFusion label Jun 28, 2024
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @alamb

@alamb alamb merged commit 1164a37 into apache:main Jun 29, 2024
23 checks passed
@alamb
Copy link
Contributor Author

alamb commented Jun 29, 2024

Thank you @comphead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants