Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to unparse IntervalYearMonth and IntervalDayTime to String #11065

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

goldmedal
Copy link
Contributor

Which issue does this PR close?

It's a follow up of #10795 and a part of #9494

Rationale for this change

What changes are included in this PR?

Are these changes tested?

yes

Are there any user-facing changes?

no

@github-actions github-actions bot added sql SQL Planner logical-expr Logical plan and expressions labels Jun 22, 2024
@goldmedal goldmedal changed the title Support to unparse IntervalYearMonth and IntervalDayTime to string Support to unparse IntervalYearMonth and IntervalDayTime to String Jun 22, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @goldmedal -- this looks great to me

r#"INTERVAL '1 YEARS 1 MONS 0 DAYS 0 HOURS 0 MINS 0.00 SECS'"#,
),
(
interval_year_month_lit("1.5 YEAR 1 MONTH"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alamb alamb merged commit 8a98307 into apache:main Jun 22, 2024
24 checks passed
@goldmedal
Copy link
Contributor Author

Thanks @alamb :)

@goldmedal goldmedal deleted the feature/support-unparse-interval branch June 22, 2024 11:43
xinlifoobar pushed a commit to xinlifoobar/datafusion that referenced this pull request Jun 22, 2024
xinlifoobar pushed a commit to xinlifoobar/datafusion that referenced this pull request Jun 22, 2024
y-f-u pushed a commit to spiceai/datafusion that referenced this pull request Jun 24, 2024
y-f-u pushed a commit to spiceai/datafusion that referenced this pull request Jun 24, 2024
y-f-u added a commit to spiceai/datafusion that referenced this pull request Jun 24, 2024
support to unparse interval to string (apache#11065)
findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logical-expr Logical plan and expressions sql SQL Planner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants